Skip to content

feat: add type for Nock Back currentMode#1794

Merged
paulmelnikow merged 2 commits intonock:masterfrom
tteltrab:patch-1
Oct 31, 2019
Merged

feat: add type for Nock Back currentMode#1794
paulmelnikow merged 2 commits intonock:masterfrom
tteltrab:patch-1

Conversation

@tteltrab
Copy link
Copy Markdown
Contributor

currentMode exists but isn't typed - https://github.com/nock/nock/blob/master/lib/back.js#L282

It's referenced in the docs here https://github.com/nock/nock#modes

Copy link
Copy Markdown
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick!

@paulmelnikow paulmelnikow added the TypeScript Anything related to TypeScript label Oct 30, 2019
@paulmelnikow paulmelnikow changed the title add type for currentMode feat: add type for Nock Back currentMode Oct 31, 2019
@paulmelnikow paulmelnikow merged commit ba60fd2 into nock:master Oct 31, 2019
@nockbot
Copy link
Copy Markdown
Collaborator

nockbot commented Oct 31, 2019

🎉 This PR is included in version 11.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tteltrab tteltrab deleted the patch-1 branch November 4, 2019 01:48
juninmd pushed a commit to juninmd/nock that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released TypeScript Anything related to TypeScript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants