feat: improve error output by showing which URL caused the error#1735
Merged
paulmelnikow merged 4 commits intonock:betafrom Oct 7, 2019
Merged
feat: improve error output by showing which URL caused the error#1735paulmelnikow merged 4 commits intonock:betafrom
paulmelnikow merged 4 commits intonock:betafrom
Conversation
Member
|
I don't have access to push the suggested change, though if you accept it I can merge. |
Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
Collaborator
|
🎉 This PR is included in version 11.1.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
Oh gosh, this was targeting beta. What have I done?! 🤦♂ |
Member
|
@martinfrancois Would you mind opening a new PR targeting master? |
Member
|
/cc @gr2m |
Member
|
I’d try to cherry pick the commits into a branch based of master and the send a PR |
Contributor
Author
|
@paulmelnikow Sorry, didn't know this was supposed to go against master! Just reopened a PR with the change cherry picked against master (like suggested by @gr2m), see #1740 |
martinfrancois
added a commit
to martinfrancois/nock
that referenced
this pull request
Oct 7, 2019
…k#1735) After getting an error in the interceptor, mentioning URL's need to start with a slash, it was difficult to find out which URL was causing the issue. With this change, since the URL is included in the error message, it's easier to troubleshoot the issue.
martinfrancois
added a commit
to martinfrancois/nock
that referenced
this pull request
Oct 7, 2019
…k#1735) After getting an error in the interceptor, mentioning URL's need to start with a slash, it was difficult to find out which URL was causing the issue. With this change, since the URL is included in the error message, it's easier to troubleshoot the issue.
martinfrancois
added a commit
to martinfrancois/nock
that referenced
this pull request
Oct 7, 2019
…k#1735) After getting an error in the interceptor, mentioning URL's need to start with a slash, it was difficult to find out which URL was causing the issue. With this change, since the URL is included in the error message, it's easier to troubleshoot the issue.
paulmelnikow
pushed a commit
that referenced
this pull request
Oct 7, 2019
…) (#1740) After getting an error in the interceptor, mentioning URL's need to start with a slash, it was difficult to find out which URL was causing the issue. With this change, since the URL is included in the error message, it's easier to troubleshoot the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After getting an error in the interceptor, mentioning URL's need to start with a slash, it was difficult to find out which URL was causing the issue. With this change, since the URL is included in the error message, it's easier to troubleshoot the issue.