Merged
Conversation
…same host if one decides to filter out
Member
paulmelnikow
left a comment
There was a problem hiding this comment.
Hi! Thanks for this.
I think this feature makes sense to include.
Though filter is a nice name for this function, it's already being used for filteringScope and filteringRequestBody, and this is doing something pretty different. What do you think about calling it conditionally() instead?
Could you add an entry to the readme documenting the new API?
Member
|
Hi @parisholley it would be great to get this merged! Would you have time to address any of the open items? |
Contributor
Author
|
@paulmelnikow done |
conditionally()
Collaborator
|
🎉 This PR is included in version 11.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
juninmd
pushed a commit
to juninmd/nock
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am building a test framework which depends on nock and to support concurrency, I need to be able shutoff certain scopes (to prevent cross-pollination) when running tests concurrently