Comprehensive cleanup after each test#1465
Merged
paulmelnikow merged 5 commits intobetafrom Feb 24, 2019
Merged
Conversation
- And misc adjacent cleanup
gr2m
approved these changes
Feb 23, 2019
Member
gr2m
left a comment
There was a problem hiding this comment.
This is great! Maybe consider calling the file cleanup_after_all.js? It might be more clear than cleanup_hook.js
Member
Author
|
Sure. I think I'll use |
Collaborator
|
🎉 This PR is included in version 11.0.0-beta.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 2, 2019
Collaborator
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
This adds a global `afterEach` hook that resets nock global state to the condition it's in when it's initially `require`d. It's worth noting that there isn't a single function for doing this; I've got four function calls here to accomplish that. It's worth taking a moment here to validate that this is indeed the correct sequence of calls. See #1441 for some discussion on that. It removes most or all of the one-off global-state cleanup code that's sprinkled among the tests. - Tests may now assume that, at the time they're invoked, that nock's initial state will match the state it has when it has just been `require`d. - Tests are not responsible for restoring that state afterward. - If tests need nock in a _different_ starting state, it's up to them to set it. - If tests create _other_ state, such as starting a server, it's up to them to clean it up. I've included some miscellaneous adjacent style cleanup. I've deferred the various `test_back*` suites because they are all intertwingled, and require a bit more focused effort to unravel.
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
This adds a global `afterEach` hook that resets nock global state to the condition it's in when it's initially `require`d. It's worth noting that there isn't a single function for doing this; I've got four function calls here to accomplish that. It's worth taking a moment here to validate that this is indeed the correct sequence of calls. See #1441 for some discussion on that. It removes most or all of the one-off global-state cleanup code that's sprinkled among the tests. - Tests may now assume that, at the time they're invoked, that nock's initial state will match the state it has when it has just been `require`d. - Tests are not responsible for restoring that state afterward. - If tests need nock in a _different_ starting state, it's up to them to set it. - If tests create _other_ state, such as starting a server, it's up to them to clean it up. I've included some miscellaneous adjacent style cleanup. I've deferred the various `test_back*` suites because they are all intertwingled, and require a bit more focused effort to unravel.
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
This adds a global `afterEach` hook that resets nock global state to the condition it's in when it's initially `require`d. It's worth noting that there isn't a single function for doing this; I've got four function calls here to accomplish that. It's worth taking a moment here to validate that this is indeed the correct sequence of calls. See #1441 for some discussion on that. It removes most or all of the one-off global-state cleanup code that's sprinkled among the tests. - Tests may now assume that, at the time they're invoked, that nock's initial state will match the state it has when it has just been `require`d. - Tests are not responsible for restoring that state afterward. - If tests need nock in a _different_ starting state, it's up to them to set it. - If tests create _other_ state, such as starting a server, it's up to them to clean it up. I've included some miscellaneous adjacent style cleanup. I've deferred the various `test_back*` suites because they are all intertwingled, and require a bit more focused effort to unravel.
juninmd
pushed a commit
to juninmd/nock
that referenced
this pull request
Mar 21, 2026
This adds a global `afterEach` hook that resets nock global state to the condition it's in when it's initially `require`d. It's worth noting that there isn't a single function for doing this; I've got four function calls here to accomplish that. It's worth taking a moment here to validate that this is indeed the correct sequence of calls. See nock#1441 for some discussion on that. It removes most or all of the one-off global-state cleanup code that's sprinkled among the tests. - Tests may now assume that, at the time they're invoked, that nock's initial state will match the state it has when it has just been `require`d. - Tests are not responsible for restoring that state afterward. - If tests need nock in a _different_ starting state, it's up to them to set it. - If tests create _other_ state, such as starting a server, it's up to them to clean it up. I've included some miscellaneous adjacent style cleanup. I've deferred the various `test_back*` suites because they are all intertwingled, and require a bit more focused effort to unravel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a global
afterEachhook that resets nock global state to the condition it's in when it's initiallyrequired. It's worth noting that there isn't a single function for doing this; I've got four function calls here to accomplish that. It's worth taking a moment here to validate that this is indeed the correct sequence of calls. See #1441 for some discussion on that.It removes most or all of the one-off global-state cleanup code that's sprinkled among the tests.
required.I've included some miscellaneous adjacent style cleanup.
I've deferred the various
test_back*suites because they are all intertwingled, and require a bit more focused effort to unravel.