Split out several small groupings of tests#1426
Merged
paulmelnikow merged 6 commits intobetafrom Feb 2, 2019
Merged
Conversation
paulmelnikow
commented
Feb 2, 2019
| @@ -1,69 +0,0 @@ | |||
| 'use strict' | |||
Member
Author
There was a problem hiding this comment.
Renamed to test_allowunmocked_https.js.
02737a0 to
70656ca
Compare
As we've discussed before `test_intercept.js` is particularly unmanageable. Rather than take a complete pass through it, I looked for topics where there are at least a few tests, and there is either some affinity among them (e.g. streaming, http.ClientRequest) making them easier to understand as a group, or they are testing the same function (e.g. `delay*()`, `query()`). Looking forward to feedback on this, though also hoping we can merge it quickly so it doesn't interfere or create conflicts with other potential work in progress.
70656ca to
2dc2e53
Compare
gr2m
reviewed
Feb 2, 2019
Member
gr2m
left a comment
There was a problem hiding this comment.
much better than before. We can continue the discussion but no need to keep this open. Thanks for putting in the work to make this more managable
Member
Author
|
I've double-checked this. If CI is passing let's merge it! @gr2m could you merge or 👍? |
gr2m
approved these changes
Feb 2, 2019
Collaborator
|
🎉 This PR is included in version 11.0.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
As we've discussed before `test_intercept.js` is particularly unmanageable. Rather than take a complete pass through it, I looked for topics where there are at least a few tests, and there is either some affinity among them (e.g. streaming, http.ClientRequest) making them easier to understand as a group, or they are testing the same function (e.g. `delay*()`, `query()`). I've made no code changes.
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
As we've discussed before `test_intercept.js` is particularly unmanageable. Rather than take a complete pass through it, I looked for topics where there are at least a few tests, and there is either some affinity among them (e.g. streaming, http.ClientRequest) making them easier to understand as a group, or they are testing the same function (e.g. `delay*()`, `query()`). I've made no code changes.
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
As we've discussed before `test_intercept.js` is particularly unmanageable. Rather than take a complete pass through it, I looked for topics where there are at least a few tests, and there is either some affinity among them (e.g. streaming, http.ClientRequest) making them easier to understand as a group, or they are testing the same function (e.g. `delay*()`, `query()`). I've made no code changes.
juninmd
pushed a commit
to juninmd/nock
that referenced
this pull request
Mar 21, 2026
As we've discussed before `test_intercept.js` is particularly unmanageable. Rather than take a complete pass through it, I looked for topics where there are at least a few tests, and there is either some affinity among them (e.g. streaming, http.ClientRequest) making them easier to understand as a group, or they are testing the same function (e.g. `delay*()`, `query()`). I've made no code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we've discussed before
test_intercept.jsis particularly unmanageable.Rather than take a complete pass through it, I looked for topics where there are at least a few tests, and there is either some affinity among them (e.g. streaming, http.ClientRequest) making them easier to understand as a group, or they are testing the same function (e.g.
delay*(),query()).I've made no code changes.
Looking forward to feedback on this, though also hoping we can merge it quickly so it doesn't interfere or create conflicts with other potential work in progress.