Skip to content

Solaris: fixes build and tests, adds CI#2544

Merged
SteveLauC merged 1 commit intonix-rust:masterfrom
psumbera:solaris-fixes
Nov 30, 2024
Merged

Solaris: fixes build and tests, adds CI#2544
SteveLauC merged 1 commit intonix-rust:masterfrom
psumbera:solaris-fixes

Conversation

@psumbera
Copy link
Copy Markdown
Contributor

@psumbera psumbera commented Nov 19, 2024

Disables some tests for Solaris.

test/test_sendfile.rs:

Solaris, sendfilev() doesn't support AF_UNIX sockets. Instead, it expects an AF_INET or AF_INET6 sockets.

@SteveLauC SteveLauC self-requested a review November 20, 2024 01:11
@SteveLauC SteveLauC mentioned this pull request Nov 20, 2024
Closed
@SteveLauC SteveLauC linked an issue Nov 20, 2024 that may be closed by this pull request
fails cross check --target x86_64-pc-solaris on 1.72.1 #2540
Closed
SteveLauC
SteveLauC reviewed Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Sorry for a bunch of comments 🫣

@SteveLauC
Copy link
Copy Markdown
Member

SteveLauC commented Nov 20, 2024

BTW, looks like x86_64-sun-solaris was renamed to x86_64-pc-solaris, so this PR can close #935?

@SteveLauC SteveLauC linked an issue Nov 20, 2024 that may be closed by this pull request
Add support for x86_64-sun-solaris target #935
Closed
@psumbera psumbera force-pushed the solaris-fixes branch 2 times, most recently from 0aaaff7 to 429af01 Compare November 21, 2024 08:39
@SteveLauC SteveLauC mentioned this pull request Nov 22, 2024
Merged
@psumbera psumbera force-pushed the solaris-fixes branch 2 times, most recently from 28fe095 to 884888f Compare November 26, 2024 14:53
@psumbera
Copy link
Copy Markdown
Contributor Author

psumbera commented Nov 26, 2024

Hurd CI failure seems to be related to rust-lang/libc#3785.

@SteveLauC
Copy link
Copy Markdown
Member

SteveLauC commented Nov 27, 2024 •
edited
Loading

Hurd CI failure seems to be related to rust-lang/libc#3785.

Right, std is broken due to that PR

I just sent a patch to the std: rust-lang/rust#133515

@SteveLauC
Copy link
Copy Markdown
Member

SteveLauC commented Nov 27, 2024

I just disabled the Hurd CI, you can rebase your branch to fix the issue:)

@psumbera psumbera force-pushed the solaris-fixes branch 3 times, most recently from 96856f1 to 4218b1e Compare November 29, 2024 09:13
@psumbera
Solaris: fixes build and tests, adds CI
4218b1e 
Disables some tests for Solaris.

test/test_sendfile.rs:

Solaris, sendfilev() doesn't support AF_UNIX sockets.
Instead, it expects an AF_INET or AF_INET6 sockets.

test/sys/test_timer.rs:

Note that sys::test_timer::alarm_fires can fail as timer_create(3C) function
requires the PRIV_PROC_CLOCK_HIGHRES. But since tests are supposed to run
with sudo it should be ok.
SteveLauC
SteveLauC approved these changes Nov 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC added this pull request to the merge queue Nov 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2024
@SteveLauC SteveLauC added this pull request to the merge queue Nov 30, 2024
Merged via the queue into nix-rust:master with commit 0f45593 Nov 30, 2024
jtmoon79 added a commit to jtmoon79/super-speedy-syslog-searcher that referenced this pull request Dec 1, 2024
@jtmoon79
(CI) skip cross x86_64-pc-solaris
b08747e 
PR #350
PR nix-rust/nix#2544
jtmoon79 added a commit to jtmoon79/super-speedy-syslog-searcher that referenced this pull request Dec 1, 2024
@jtmoon79
(CI) skip cross x86_64-pc-solaris
3372d96 
PR #350
PR nix-rust/nix#2544
jtmoon79 added a commit to jtmoon79/super-speedy-syslog-searcher that referenced this pull request Dec 1, 2024
@jtmoon79
(CI) skip cross x86_64-sun-solaris
9eb969e 
PR #350
PR nix-rust/nix#2544
jtmoon79 added a commit to jtmoon79/super-speedy-syslog-searcher that referenced this pull request Dec 1, 2024
@jtmoon79
(CI) skip cross x86_64-pc-solaris
786b154 
PR #350
PR nix-rust/nix#2544
jtmoon79 added a commit to jtmoon79/super-speedy-syslog-searcher that referenced this pull request Dec 1, 2024
@jtmoon79
(CI) skip cross x86_64-sun-solaris
7eed267 
PR #350
PR nix-rust/nix#2544
@jtmoon79 jtmoon79 mentioned this pull request Dec 1, 2024
Closed
@psumbera
Copy link
Copy Markdown
Contributor Author

psumbera commented Dec 13, 2024

@SteveLauC any chance for new nix release? This commit is needed for Solaris Rust build.

@SteveLauC
Copy link
Copy Markdown
Member

SteveLauC commented Dec 13, 2024

@SteveLauC any chance for new nix release? This commit is needed for Solaris Rust build.

I will give myself a push this weekend, but I cannot guarantee, I will try...

@psumbera
Copy link
Copy Markdown
Contributor Author

psumbera commented Jan 31, 2025

@SteveLauC any chance for new nix release? This commit is needed for Solaris Rust build.

I will give myself a push this weekend, but I cannot guarantee, I will try...

Just gentle ping here. I really don't know how to make Rust language build to use latest NIx sources.

@SteveLauC
Copy link
Copy Markdown
Member

SteveLauC commented Apr 29, 2025

0.30.0 released: https://crates.io/crates/nix/0.30.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fails cross check --target x86_64-pc-solaris on 1.72.1 Add support for x86_64-sun-solaris target

2 participants

@psumbera @SteveLauC