Worker and external worker service clean up#21
Worker and external worker service clean up#21sjvanrossum wants to merge 5 commits intonivaldoh:rust_sdkfrom
Conversation
…i through a reexport in hyper)
…le, drop wrappers on Worker::new and clean up external_worker_service
|
@nivaldoh I've also cleaned up the proto module and usage thereof. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
@sjvanrossum Could you kindly make a PR to https://github.com/laysakura/beam/ repository for these changes? |
|
@sjvanrossum I did in laysakura#31 🙂 |
|
@laysakura That's great, thanks! I'll close this one. |
http::Uri, instead usingtonic::transport::Uri(which is effectively just ahttp::Urire-export, but could obviously change).std::sync::Mutexwithtokio::sync::Mutex, made sure to avoid creating, starting and re-inserting a worker if their worker id already exists and made sure to start the worker. I'm not sure if external Rust workers will be necessary ever, but we can look into that somewhere in the future.Worker::stopis async now and closes the control channelWorker::newnow just returnsSelf, I checked that all synchronization is handled inimpl WorkerRegisterinstructions has been added (1 down and 6 to go, although register is deprecated)