Closed
Conversation
Contributor
✅ Live Preview ready!
|
Codecov Report
@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
+ Coverage 76.64% 76.66% +0.01%
==========================================
Files 71 72 +1
Lines 7241 7247 +6
Branches 723 723
==========================================
+ Hits 5550 5556 +6
Misses 1690 1690
Partials 1 1
|
|
@pi0 can we get this PR merged soon ? |
|
@pi0 @danielroe can we get a review and merge of this pr soon ? |
Closed
|
Hey @pi0 do we have plans to get this merged for the next release? Our team is looking forward to use it. |
7 tasks
Closed
Hebilicious
approved these changes
Jul 3, 2023
| ], | ||
| }; | ||
| const res: CloudFrontResultResponse = await handler(event); | ||
| // responsed CloudFrontHeaders are special, so modify them for testing. |
86b7d1c to
edca69a
Compare
Contributor
|
This is looking very good, and it also would be a compatible with SST as demonstrated here https://github.com/jdevdevdev/nuxt-sst/blob/lambda-edge/nuxt-app/server/nitro/preset/entry.ts @pi0 Some presets such as vercel and netlify have multiple presets, while some like cloudflare and azure don't, so I'm not sure what to do here. |
8 tasks
AlbertSabate
pushed a commit
to AlbertSabate/nitro
that referenced
this pull request
Dec 23, 2023
AlbertSabate
pushed a commit
to AlbertSabate/nitro
that referenced
this pull request
Mar 29, 2024
Trying stuff pnpm build conflicts with monorepo pnpm build when installing the package from github Remove prepack and commit dist Improve aws edge code Accept only 1 header with same name for incoming headers Forgot to build Debugging outgoing headers Improving the income headers Removing dist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Add AWS Lambda@Edge to the preset.
The current aws-lambda preset is not compatible with the Lambda@Edge
This option is one of the most cost-effective on cloud technologies, it is much faster and more effective than "API Gateway".
I take WinterYukky job as a base, focusing more on ".output/server/index.mjs" and removing the zero config functionalities as there are several CloudFormation templates to deploy, leaving a simpler option to implement inside your CI/CD.
Resolves #79
📝 Checklist