Merged
Conversation
62aa02b to
e6c1e3b
Compare
src/librustc/session/mod.rs
Outdated
Owner
There was a problem hiding this comment.
I am debating whether we should have #![feature(nll)] enable dump-cause or not. The main reason not to is that it is so sloooooow right now. I feel like we might want to enable it once we make it faster (and then we wouldn't have this switch at all.)
Owner
nikomatsakis
left a comment
There was a problem hiding this comment.
Looks basically right, modulo the question about -Znll-dump-cause, and the fact that it needs to handle -Zborrowck=mir
e6c1e3b to
ab4070d
Compare
efa46b3 to
1ce4a8d
Compare
ab4070d to
4615bc5
Compare
4615bc5 to
915bd0e
Compare
Collaborator
Author
|
This should be ready! |
1ce4a8d to
dbb21b3
Compare
In particular, -Znll might as well imply -Zborrowck=mir by default, just like `#![feature(nll)]` does. Also, if NLL is in use, no reason to emit end regions. The NLL pass just strips them out anyway.
Also, keep reporting AST-based region errors that are not occuring in a fn body.
915bd0e to
0f41fbb
Compare
nikomatsakis
pushed a commit
that referenced
this pull request
Sep 25, 2019
Sync to rust-lang/rust master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for rust-lang#46716