Compare root namespaces when rewriting function applications#25
Merged
ngernest merged 1 commit intometaprogrammingfrom Jul 28, 2025
Merged
Compare root namespaces when rewriting function applications#25ngernest merged 1 commit intometaprogrammingfrom
ngernest merged 1 commit intometaprogrammingfrom
Conversation
…n-trivial function applications
ngernest
pushed a commit
that referenced
this pull request
Jul 28, 2025
chore: bump toolchain to v4.20.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix: When detecting whether the conclusion of a constructor (for an inductive relation) containing a non-trivial function application (i.e. an application where the function isn't a constructor of some inductive type), compare the root namespaces of the function & the inductive relation being targeted by the generator.
(This is a temporary fix as we migrate towards using the unification algorithm from Generating Good Generators + the generator schedules in Testing Theorems, see #23.)