Skip to content

add module for abritamr_run#3725

Merged
SPPearce merged 2 commits into
nf-core:masterfrom
rpetit3:rp3-add-abritamr
Oct 5, 2023
Merged

add module for abritamr_run#3725
SPPearce merged 2 commits into
nf-core:masterfrom
rpetit3:rp3-add-abritamr

Conversation

@rpetit3

@rpetit3 rpetit3 commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

PR checklist

Closes #3724

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@nvnieuwk nvnieuwk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very clear code!

@SPPearce SPPearce added this pull request to the merge queue Oct 5, 2023
Merged via the queue into nf-core:master with commit 14bb5b7 Oct 5, 2023
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Oct 16, 2023
* add module for abritamr_run

* fix typo in meta yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: abritamr/run

3 participants