Skip to content

add snippy/core module#1855

Merged
jfy133 merged 11 commits into
nf-core:masterfrom
rpetit3:rp3-add-snippy_core
Sep 8, 2022
Merged

add snippy/core module#1855
jfy133 merged 11 commits into
nf-core:masterfrom
rpetit3:rp3-add-snippy_core

Conversation

@rpetit3

@rpetit3 rpetit3 commented Jul 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR checklist

Closes #1854

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@rpetit3 rpetit3 added new module Adding a new module Ready for Review labels Jul 6, 2022
@jfy133 jfy133 self-requested a review July 6, 2022 09:32
jfy133
jfy133 approved these changes Jul 6, 2022
View reviewed changes

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor comments

Comment thread modules/snippy/core/main.nf
Comment thread modules/snippy/core/main.nf
Comment thread modules/snippy/core/meta.yml
Comment thread tests/modules/snippy/core/main.nf Outdated
Comment thread tests/modules/snippy/core/main.nf Outdated
Comment thread modules/snippy/core/main.nf Outdated
rpetit3 and others added 7 commits July 6, 2022 09:12
@rpetit3 @jfy133
Update modules/snippy/core/meta.yml
d230320 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@rpetit3 @jfy133
Update tests/modules/snippy/core/main.nf
9b34c8c 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@rpetit3 @jfy133
Update tests/modules/snippy/core/main.nf
73d90f8 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@rpetit3 @jfy133
Update modules/snippy/core/main.nf
14fb615 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@rpetit3
Update main.nf
74e5240
@rpetit3
update test
1b76a74
@jfy133
Merge branch 'master' into rp3-add-snippy_core
a00d601
jfy133
jfy133 approved these changes Jul 7, 2022
View reviewed changes
Comment thread modules/snippy/core/main.nf
@jfy133 jfy133 merged commit 1ade577 into nf-core:master Sep 8, 2022
matthdsm pushed a commit to matthdsm/nf-core-modules that referenced this pull request Sep 28, 2022
@rpetit3 @jfy133 @matthdsm
add snippy/core module (nf-core#1855)
346dbf3 
* add snippy-core module

* Update modules/snippy/core/meta.yml

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* Update tests/modules/snippy/core/main.nf

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* Update tests/modules/snippy/core/main.nf

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* Update modules/snippy/core/main.nf

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* Update main.nf

* update test

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees

No one assigned

Labels

new module Adding a new module Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new module: snippy/core

2 participants

@rpetit3 @jfy133