chore: add desktop e2e coverage collection and reporting#698
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f2c71ae03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2653f4b37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying nexu-docs with
|
| Latest commit: |
f0410df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2568c67e.nexu-docs.pages.dev |
| Branch Preview URL: | https://nexu-e2e-coverage.nexu-docs.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c79c1568a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efaced6a08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66ece12e53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f59e4b7e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…design PR #698 unconditionally passed --config.electronDist pointing at the electron package's dist directory inside the pnpm store. On the macOS arm64 nightly runner, electron-builder copies Electron.app from that path into the release output, but the framework version symlinks (Electron Framework.framework/Versions/Current → A, etc.) do not survive the copy out of the pnpm content-addressable store. The resulting framework bundle has both top-level files and a Versions/ directory, which causes codesign to fail with: Electron Framework: bundle format is ambiguous (could be app or framework) The 04-07 nightly run (24058395128) hit this and codesign hung for ~6 minutes before exiting. The 04-06 run (pre-#698) succeeded. Restore the previous behavior: only forward --config.electronDist to electron-builder when NEXU_DESKTOP_ELECTRON_DIST_PATH is explicitly set (the e2e coverage tooling use case). Otherwise let electron-builder resolve electron via its default pnpm-aware path, which preserves framework symlinks correctly.
…design (#863) PR #698 unconditionally passed --config.electronDist pointing at the electron package's dist directory inside the pnpm store. On the macOS arm64 nightly runner, electron-builder copies Electron.app from that path into the release output, but the framework version symlinks (Electron Framework.framework/Versions/Current → A, etc.) do not survive the copy out of the pnpm content-addressable store. The resulting framework bundle has both top-level files and a Versions/ directory, which causes codesign to fail with: Electron Framework: bundle format is ambiguous (could be app or framework) The 04-07 nightly run (24058395128) hit this and codesign hung for ~6 minutes before exiting. The 04-06 run (pre-#698) succeeded. Restore the previous behavior: only forward --config.electronDist to electron-builder when NEXU_DESKTOP_ELECTRON_DIST_PATH is explicitly set (the e2e coverage tooling use case). Otherwise let electron-builder resolve electron via its default pnpm-aware path, which preserves framework symlinks correctly.
What
Add end-to-end desktop coverage capture and reporting across the CI workflow, Electron/Node processes, and packaged Chromium targets.
Why
Desktop E2E runs previously proved behavior but gave no actionable coverage output, which made it hard to measure exercised paths or upload results to Codecov.
How
Affected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
pnpm installwas required in this worktree before validation because dependencies were not installed yet.