fix: preserve pnpm @img path before dereferencing sharp#330
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
lefarcen
approved these changes
Mar 22, 2026
lefarcen
added a commit
that referenced
this pull request
Mar 22, 2026
) * fix: stabilize openclaw-weixin plugin entry config * fix(desktop): dereference pnpm symlinks before electron-builder pnpm creates symlinks in node_modules pointing to .pnpm directory. When electron-builder copies these as extraResources, the symlinks point to non-existent paths in the final .app bundle, causing codesign to fail with "invalid destination for symbolic link". This fix dereferences node_modules/sharp and node_modules/@img symlinks before running electron-builder. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: format dist-mac.mjs * fix(desktop): copy @img from sharp's node_modules for pnpm * fix(desktop): find @img as sibling of sharp in pnpm structure * fix(desktop): resolve pnpm paths before dereferencing * fix(desktop): use cp -RL for full symlink dereference in pnpm deps Node.js fs.cp with dereference:true only dereferences the top-level source path, not nested symlinks inside directories. The @img package contains symlinks to other pnpm packages that were not being resolved. Switch to cp -RL shell command which properly resolves all nested symlinks recursively. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * debug: add symlink detection after dereference * fix(desktop): dereference ALL pnpm symlinks before electron-builder Previous fix only handled sharp and @img, but pnpm creates symlinks for all dependencies. Now we find and dereference all symlinks in node_modules before electron-builder runs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(desktop): isolate sidecar patching and refresh model inventory * revert: remove redundant symlink fix, use upstream solution from PR #330 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * revert: restore package-lock.json to main --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@imgfrom the saved pnpm location so electron-builder bundles real files instead of broken symlinksVerification