filter: Allow --group-by week, refactoring#1067
Merged
Conversation
Group by day is not practical because: 1. The amount of groups would overly bias temporal diversity 2. In many datasets, daily sequencing volume varies between days of the week.
Put the generated columns in a set so it can be added to more easily.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 61.68% 61.77% +0.09%
==========================================
Files 52 52
Lines 6300 6316 +16
Branches 1585 1550 -35
==========================================
+ Hits 3886 3902 +16
Misses 2141 2141
Partials 273 273 ☔ View full report in Codecov by Sentry. |
89df17d to
c4df460
Compare
victorlin
commented
Oct 20, 2022
6c21ae2 to
a6ec84a
Compare
joverlee521
reviewed
Oct 21, 2022
a6ec84a to
c0abbda
Compare
joverlee521
reviewed
Oct 21, 2022
c0abbda to
f2a6d71
Compare
Member
Author
|
This PR now has some downstream PRs. Ideally, I'd like to merge in this order to avoid merge conflicts:
but I can rebase if needed. |
joverlee521
approved these changes
Oct 25, 2022
Contributor
joverlee521
left a comment
There was a problem hiding this comment.
Just one comment, but looks good to merge 👍
I'll move on to the other PRs 😄
f2a6d71 to
3043718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Some group-by cleanup and implementation of
--group-by week.Related issue(s)
--group-by month#960.Testing
Checklist