Fix LogsCheckpoint thread blocking shutdown#6787
Merged
bentsherman merged 2 commits intomasterfrom Feb 2, 2026
Merged
Conversation
The checkpoint thread sleeps for the configured interval (default 90s). When onFlowComplete() was called, it waited for the sleep to complete before the thread could exit. Now interrupt() is called to wake the thread immediately from sleep, allowing the main thread to continue shutdown without delay. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
approved these changes
Feb 2, 2026
bentsherman
pushed a commit
that referenced
this pull request
Feb 2, 2026
cgoina
pushed a commit
to cgoina/nextflow
that referenced
this pull request
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interrupt()to wake the thread from sleep immediatelyterminatedfield since interrupt flag is sufficientProblem
The
tower-logs-checkpointthread sleeps for the configured interval (default 90s). WhenonFlowComplete()was called, it setterminated=truebut the thread was stuck inThread.sleep(), causing the main thread to wait up to 90 seconds before shutdown could complete.Solution
Call
thread.interrupt()beforethread.join()to wake the thread immediately from sleep. Theawait()method already handlesInterruptedExceptioncorrectly.🤖 Generated with Claude Code