Fix params inclusion across modules in v2 parser#6766
Merged
bentsherman merged 2 commits intomasterfrom Jan 29, 2026
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
reviewed
Jan 28, 2026
modules/nf-lang/src/main/java/nextflow/script/control/ScriptToGroovyVisitor.java
Show resolved
Hide resolved
jorgee
approved these changes
Jan 29, 2026
bentsherman
added a commit
that referenced
this pull request
Jan 29, 2026
pditommaso
added a commit
that referenced
this pull request
Feb 9, 2026
This reverts commit f5b8d32.
cgoina
pushed a commit
to cgoina/nextflow
that referenced
this pull request
Feb 10, 2026
bentsherman
added a commit
that referenced
this pull request
Feb 10, 2026
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6762
This PR fixes a bug where params defined before an include were not passed to the included module.
Even though this pattern is now discouraged, it is still technically supported until we disallow params outside the entry workflow entirely.
The problem was that the v2 parser was not preserving the order of script declarations, so param assignments were always placed after includes in the generated Groovy code. The sorting code was taken from ScriptFormattingVisitor, which also has to preserve the original declaration order.