Fix false error in v2 parser when including config file from http url#6753
Fix false error in v2 parser when including config file from http url#6753bentsherman merged 1 commit intomasterfrom
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
| var sourceUri = new URI(source); | ||
| if( sourceUri.getScheme() != null ) | ||
| return sourceUri; |
There was a problem hiding this comment.
I believe this is not enough. It should be used FileHelper.asPath otherwise it will not be able to resolve paths against Git resources and above all uri that requires authentication (e.g platform provided)
There was a problem hiding this comment.
This class is just a pre-flight check, and it only checks local includes to make sure they actually exist. It doesn't bother checking remote includes for precisely the reasons you mentioned
Honestly we could just move this class back to the language server. It doesn't provide much benefit here since all includes will be validated when the config is loaded:
There was a problem hiding this comment.
But it is nice for the language server and nextflow lint to report the same errors as much as possible
Close #6749