Support multiple config option types in config spec#6720
Merged
bentsherman merged 5 commits intomasterfrom Jan 14, 2026
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
jorgee
approved these changes
Jan 14, 2026
Contributor
jorgee
left a comment
There was a problem hiding this comment.
Looks fine, just a very minor comment.
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
pditommaso
pushed a commit
that referenced
this pull request
Jan 16, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6718
This PR updates the config spec to support multiple types for config options.
For example,
process.publishDircan be supplied with a String, Map, or List, as shown inProcessDsl. The config spec needs to be able to allow for all of these types, especially as we extend type checking to config files.For now, this PR fixes a bug in the runtime config validation. The ConfigValidator needs to know whether a config option has type Map in order to distinguish between "map" options and scopes in the resolved config.
As a bonus, this PR adds support for the
typesfield in theConfigOptionannotation, which allows config options to specify "additional types". See for example thek8s.podoption defined in K8sConfig. The config spec JSON has been updated to include these additional types in a non-breaking way. These will eventually be used by the type checker.