Detect conda explicit files by content instead of extension#6713
Merged
pditommaso merged 3 commits intomasterfrom Jan 13, 2026
Merged
Detect conda explicit files by content instead of extension#6713pditommaso merged 3 commits intomasterfrom
pditommaso merged 3 commits intomasterfrom
Conversation
Change conda explicit file detection from extension-based (.txt) to content-based by checking for the @explicit marker in the first 20 lines of the file. This improves compatibility with conda explicit files that may use different extensions, and avoids incorrectly treating regular .txt files as conda explicit files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
added a commit
that referenced
this pull request
Jan 16, 2026
* Detect conda explicit files by content instead of extension Change conda explicit file detection from extension-based (.txt) to content-based by checking for the @explicit marker in the first 20 lines of the file. This improves compatibility with conda explicit files that may use different extensions, and avoids incorrectly treating regular .txt files as conda explicit files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.txt) to content-based by checking for the@EXPLICITmarker@EXPLICITmarker, which is the standard identifier for conda explicit specification filesMotivation
Previously, conda explicit files were identified solely by their
.txtextension usingisTextFilePath(). This had two issues:.lock,.spec) were not recognized.txtextension could be incorrectly treated as conda explicit filesThe
@EXPLICITmarker is the canonical identifier for conda explicit specification files (see conda documentation). By checking file content, we can reliably identify these files regardless of their extension.Changes
CondaCache.groovy
isTextFilePath()withisExplicitFile()- checks if file exists and contains@EXPLICITmarkercontainsExplicitMarker()helper - efficiently reads only first 20 linescondaPrefixPath()andcreateLocalCondaEnv0()to use the new methodCondaCacheTest.groovy
@EXPLICITmarkerTest plan
CondaCacheTesttests pass@EXPLICITmarker@EXPLICITmarker are not incorrectly identified as explicit filesfalsegracefully🤖 Generated with Claude Code