Add missing provider credentials when updating the bare repo in multi-revision assets#6698
Merged
bentsherman merged 4 commits intomasterfrom Jan 6, 2026
Merged
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pditommaso
reviewed
Jan 3, 2026
Member
pditommaso
left a comment
There was a problem hiding this comment.
Is there any way to capture this condition into a small test?
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Contributor
Author
|
I have added the download of the Azure repo as a test. It was the only one that really required credentials to read it. |
pditommaso
reviewed
Jan 6, 2026
modules/nextflow/src/main/groovy/nextflow/scm/MultiRevisionRepositoryStrategy.groovy
Outdated
Show resolved
Hide resolved
…ositoryStrategy.groovy [ci fast] Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
approved these changes
Jan 6, 2026
pditommaso
added a commit
that referenced
this pull request
Jan 16, 2026
…-revision assets (#6698) Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Collaborator
|
Heya team. Would this be a good candidate to backport to 25.10? |
Contributor
Author
|
If I am not wrong, 25.10.x does not have multi-revision. It only affects latest edge releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating an existing local asset of a repository requiring access credentials, it is failing because the fetch command doesn't contain the provider credentials.
This pull request adds the missing repository credentials during the fetch operation to update the bare repository instance in the
MultiRevisionRepositoryStrategyclass.