Fix TowerJsonGenerator thread-safety issue#6619
Merged
pditommaso merged 1 commit intomasterfrom Nov 28, 2025
Merged
Conversation
Add synchronized to writeObject method to prevent concurrent modification of the shared stack field when multiple executor threads serialize JSON simultaneously. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
added a commit
that referenced
this pull request
Nov 28, 2025
Add synchronized to writeObject method to prevent concurrent modification of the shared stack field when multiple executor threads serialize JSON simultaneously. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix IndexOutOfBoundsException in TowerJsonGenerator caused by concurrent access to the shared stack field from multiple executor threads.
Problem
When multiple executor threads (e.g., AWSBatch-executor-1, AWSBatch-executor-2) serialize JSON simultaneously using the same TowerJsonGenerator instance, they concurrently modify the shared stack ArrayList. This causes race conditions where one thread's saved position becomes invalid after another thread modifies the stack.
Solution
Add synchronized to the writeObject method to ensure thread-safe access to the shared stack field.
🤖 Generated with Claude Code