Fix unordered completed parts in AWS multipart upload. #6560
Merged
bentsherman merged 3 commits intomasterfrom Nov 13, 2025
Merged
Fix unordered completed parts in AWS multipart upload. #6560bentsherman merged 3 commits intomasterfrom
bentsherman merged 3 commits intomasterfrom
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pditommaso
reviewed
Nov 13, 2025
Member
pditommaso
left a comment
There was a problem hiding this comment.
How this is going to be tested?
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Contributor
Author
|
I have added specific tests for S3OutputStream. I thought it was tested with the general AwsS3NioTest, but data was very small and it was never using the multipart upload. |
pditommaso
pushed a commit
that referenced
this pull request
Nov 28, 2025
--------- Signed-off-by: jorgee <jorge.ejarque@seqera.io> Co-authored-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6555
Completed multipart request include a collection of completed parts. This collection must be sorted by partNumber. Despite uploads are submitted sequentialy to the executor uploadParts call are concurrently and the addition of the completedParts in the list could be unsorted.
This PR sorts the list before calling the multipart complete.