Fix false config validation warnings for process selectors#6542
Merged
bentsherman merged 2 commits intomasterfrom Nov 7, 2025
Merged
Fix false config validation warnings for process selectors#6542bentsherman merged 2 commits intomasterfrom
bentsherman merged 2 commits intomasterfrom
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
reviewed
Nov 7, 2025
jorgee
approved these changes
Nov 7, 2025
pditommaso
pushed a commit
that referenced
this pull request
Nov 28, 2025
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6532
I just refactored the validation logic to match the ConfigSpecVisitor in the language server, instead of flattening the config object which creates all sorts of edge cases.
Also added some unit tests to improve test coverage.