Remove unnecessary runtime checks with strict syntax#6539
Merged
bentsherman merged 2 commits intomasterfrom Nov 7, 2025
Merged
Remove unnecessary runtime checks with strict syntax#6539bentsherman merged 2 commits intomasterfrom
bentsherman merged 2 commits intomasterfrom
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
e55ad47 to
cd99854
Compare
jorgee
reviewed
Nov 6, 2025
modules/nextflow/src/main/groovy/nextflow/script/parser/v2/ScriptLoaderV2.groovy
Show resolved
Hide resolved
jorgee
approved these changes
Nov 7, 2025
bentsherman
added a commit
that referenced
this pull request
Jan 23, 2026
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6533
I haven't figured out exactly what causes this error, but I believe it is related to how the v2 parser loads scripts differently than the v1 parser
Since the v2 parser checks for conflicting declarations at compile-time, these runtime checks aren't needed anyway. Disabling these checks for the v2 parser allows the MWE to run successfully. There is already a unit test for this in
ScriptResolveTest.