Optimize exit code handling by relying on scheduler status for successful executions#6484
Merged
pditommaso merged 5 commits intomasterfrom Nov 28, 2025
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Contributor
Author
|
@bentsherman @pditommaso the google batch task handler is directly getting the exit code form the file (#6481). This PR also removes the fallback to .exitcode when the exit code is 0. It is not a big PR but I was wondering if you prefer to split it in two PRs to facilitate backport to stable versions. The fix for #6481 is just the first commit ea1aa48 |
…g-on-scheduler-status-for-successful-executions
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
pditommaso
requested changes
Oct 21, 2025
Member
pditommaso
left a comment
There was a problem hiding this comment.
This looks good, but i'd keep post 25.10
Member
|
@jorgee we talked and agreed to include the google and k8s fixes in 25.10 and merge the rest of this PR in the next edge release |
pditommaso
approved these changes
Nov 28, 2025
pditommaso
added a commit
that referenced
this pull request
Nov 28, 2025
Fix test method names introduced in PR #6484: - deletePodIfSuccessful -> deleteJobIfSuccessful - savePodLogOnError -> saveJobLogOnError Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR unifies exit code handling behavior across all cloud provider executors (AWS Batch, Azure Batch, Google Batch, and Kubernetes). Previously, different executors had inconsistent approaches to obtaining task exit codes, which led to issues like missing Fusion exit codes (#6481) and unnecessary I/O overhead (#6445).
Changes
Unified Exit Code Strategy
All cloud providers now follow a consistent two-step approach:
.exitcodefile only when API returnsnull(not when it returns0)Fixes by Provider
.exitcodefiletaskExecution.exitCode), fallback to file if nullBenefits
.exitcodefile reads for successful tasks (exit code 0)Closes
Test Coverage
Added comprehensive unit tests for all affected handlers verifying:
.exitcodefile when API returns null