Fix "Strings must not be null" error message#6404
Merged
bentsherman merged 1 commit intomasterfrom Sep 16, 2025
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Collaborator
|
Fixes #6405 |
Member
Author
|
I didn't ask for your opinion cursor You can't import entry workflows from other modules so it doesn't matter |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
5d1a39a to
6b4c7a6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jorgee
approved these changes
Sep 16, 2025
pditommaso
added a commit
that referenced
this pull request
Sep 16, 2025
This commit adds a comprehensive unit test to validate the fix for PR #6404 that prevents "Strings must not be null" errors when an invalid workflow entry name is specified. The test verifies that: - Using an invalid entry name (e.g., `nextflow run script.nf -entry invalidEntry`) - Correctly throws IllegalArgumentException with proper error message - Shows "Unknown workflow entry name: invalidEntry" instead of "Strings must not be null" - Includes suggestions for valid workflow names when available The test also includes a fix to ensure null workflow names are filtered out of the imports section in getWorkflowNames(), making the fix comprehensive for both local definitions and imports. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error that happens when an invalid entry name is specified and Nextflow tries to suggest alternatives using the
closest()function:This currently yields the following error:
Stack trace:
With this PR, the correct error message is given: