Skip to content

Fix NPE when contributors omit contribution field in manifest#6383

Merged
bentsherman merged 3 commits intomasterfrom
make-contributor-contribution-optional
Sep 5, 2025
Merged

Fix NPE when contributors omit contribution field in manifest#6383
bentsherman merged 3 commits intomasterfrom
make-contributor-contribution-optional

Conversation

@robsyme
Copy link
Collaborator

@robsyme robsyme commented Sep 5, 2025

When a contributor in manifest.contributors omits the 'contribution' field, the code would attempt to call .stream() on null, causing a NullPointerException. Now defaults to empty list when contribution field is missing.

Fixes #6382

@netlify
Copy link

netlify bot commented Sep 5, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 440d1c4
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68bb4d200693c60008e9b973

@robsyme
Copy link
Collaborator Author

robsyme commented Sep 5, 2025

When a contributor in manifest.contributors omits the 'contribution' field, the code would attempt to call .stream() on null, causing a NullPointerException. Now defaults to empty list when contribution field is missing.

Signed-off-by: Rob Syme <rob.syme@gmail.com>
@robsyme robsyme force-pushed the make-contributor-contribution-optional branch from 1efccb1 to 3c94608 Compare September 5, 2025 01:55
@bentsherman bentsherman self-requested a review September 5, 2025 20:45
@bentsherman bentsherman merged commit dd2154c into master Sep 5, 2025
22 checks passed
@bentsherman bentsherman deleted the make-contributor-contribution-optional branch September 5, 2025 21:27
pditommaso pushed a commit that referenced this pull request Sep 8, 2025
---------

Signed-off-by: Rob Syme <rob.syme@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot parse manifest.contributors without contribution field.

2 participants