Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
047f329 to
b9c1c6e
Compare
Collaborator
Makes sense. I was a little unsure about tuple vs tuples in a couple of places, but ended up agreeing with what you wrote. Looks good to me. |
christopher-hakkaart
approved these changes
Aug 6, 2025
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
b9c1c6e to
3b31199
Compare
pditommaso
reviewed
Aug 15, 2025
Comment on lines
+96
to
+108
| `toDays() -> Integer` | ||
| : Get the duration value in days (rounded down). | ||
|
|
||
| `toHours() -> long` | ||
| `toHours() -> Integer` | ||
| : Get the duration value in hours (rounded down). | ||
|
|
||
| `toMillis() -> long` | ||
| `toMillis() -> Integer` | ||
| : Get the duration value in milliseconds. | ||
|
|
||
| `toMinutes() -> long` | ||
| `toMinutes() -> Integer` | ||
| : Get the duration value in minutes (rounded down). | ||
|
|
||
| `toSeconds() -> long` | ||
| `toSeconds() -> Integer` |
Member
There was a problem hiding this comment.
should not this be Long to match the interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spun-off from #6278 to include just the doc updates and other maintenance work unrelated to the PR
@christopher-hakkaart I addressed the comments you left in that PR here where applicable. Some changes were discarded because they changed the meaning or just didn't fit. Sorry for the mix up. I decided to split up these changes so that they don't get blocked by the other PR