Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
d737101 to
59f9378
Compare
Collaborator
christopher-hakkaart
left a comment
There was a problem hiding this comment.
I didn't spot any errors/typos. I've made some suggests to move the language to a active voice. Feel free to approve/reject as you see fit.
4c520f9 to
28157a6
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
28157a6 to
9c87e64
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
christopher-hakkaart
approved these changes
Aug 26, 2025
Collaborator
christopher-hakkaart
left a comment
There was a problem hiding this comment.
I've added some suggestions. I found the repetition of ", but..." made it harder to follow and made suggestions to change the flow.
Approved to prevent blocking.
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io> Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Nextflow-style type annotations for workflows, functions, and local variables.
Waiting for #5929 to be merged