Fix readBytes for non-GitHub providers#6243
Merged
pditommaso merged 5 commits intomasterfrom Jul 5, 2025
Merged
Conversation
…and failing GiteaRepositoryProviderTest for image readBytes
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
|
Note that the test for GitHub is passing. You may want to have a deeper look why the Gitea is failing |
Member
|
In the linked issue he also reported Bitbucket is failing, other providers haven't been tested |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Member
|
Think the problem is related to Gitea returning a raw binary response |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
added a commit
that referenced
this pull request
Jul 6, 2025
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Nathan Johnson <nathanjohnson@Nathans-MacBook-Pro.fritz.box> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
RepositoryProviderclass and its subclasses to improve handling of binary content and updates related tests to ensure compatibility. The key changes include introducing a new method for binary content retrieval, modifying existing methods to use this new implementation, and adding or updating test cases to validate the changes.Core Refactoring and Enhancements:
invokeBytesmethod inRepositoryProviderto handle API responses as byte arrays. Updated theinvokemethod to useinvokeBytesinternally for text-based responses.checkResponsemethod to accept generic HTTP response types (HttpResponse<?>) to support both text and binary responses.httpSendmethod and introduced a newhttpSend0method for sending HTTP requests and retrieving binary responses. [1] [2]Subclass Updates:
readBytesMethods: Updated thereadBytesmethod in subclasses (BitbucketRepositoryProvider,BitbucketServerRepositoryProvider,GiteaRepositoryProvider,GithubRepositoryProvider, andGitlabRepositoryProvider) to use the newinvokeBytesmethod for binary content retrieval. [1] [2] [3] [4] [5]Test Updates:
BitbucketRepositoryProvider,GiteaRepositoryProvider, andGithubRepositoryProvider. [1] [2] [3]These changes enhance the flexibility and robustness of the
RepositoryProviderclass and its subclasses by standardizing binary content handling and improving test coverage.