Skip to content

Add container registryOverride option#6205

Merged
pditommaso merged 10 commits intomasterfrom
registry-override
Jul 6, 2025
Merged

Add container registryOverride option#6205
pditommaso merged 10 commits intomasterfrom
registry-override

Conversation

@pditommaso
Copy link
Member

This PR adds an container level config that allows override the registry name then when container name specify a fully qualified repository name,

for example:

process.container = "quay.io/my/container:latest: 

and having in the config

docker.registry = "community.wave.seqera.io" 
docker.registryOverride = true

the final resolved container used by the task execution is going to be

community.wave.seqera.io/my/container:latest

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@netlify
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 0ad934d
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/686a4f91af06120008c49eb7

@pditommaso
Copy link
Member Author

It could also be explored if it could make sense to have a more compact notation like:

docker.registry "custom.repo.io", override: true

It should be checked if this is going to work when Wave is enabled.

@bentsherman
Copy link
Member

@stevekm would this work for you? See the changes to ContainerHandlerTest to understand how container images would be rewritten

@ewels
Copy link
Member

ewels commented Jun 30, 2025

@bentsherman the additional levels of URI hierarchy that I mentioned is with GitLab, see their docs:

registry.example.com/group/project/image:tag

/project/ represents one extra layer compared to normal - I have a feeling it can also have more layers, with sub-projects.

There may be others as well. Not sure if it's relevant to this PR or not (I think not?), but thought I should flag it.

pditommaso and others added 7 commits July 1, 2025 15:12
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Nathan Johnson <nathanjohnson@Nathans-MacBook-Pro.fritz.box>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso requested a review from a team as a code owner July 6, 2025 09:12
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member Author

Add some docs. Moving this option forward.

@pditommaso pditommaso merged commit e26abe4 into master Jul 6, 2025
5 checks passed
@pditommaso pditommaso deleted the registry-override branch July 6, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants