Invoke workflow complete handler on all workflow errors#4299
Invoke workflow complete handler on all workflow errors#4299bentsherman merged 2 commits intomasterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
But if we don't make these changes, we should document them as limitations instead. |
|
No chance to add some unit tests? |
|
When I'm not sure about a PR, I like to get your overall opinion before I write unit tests |
|
Also, I'm not sure that unit tests would help here. Probably better to add an integration test based on the reproducible examples. |
5a93547 to
27345a6
Compare
b4b321e to
069653d
Compare
f5f413a to
bfd5174
Compare
|
@pditommaso I have trimmed this PR to focus on calling the onComplete on all error conditions, including the Notes:
|
bfd5174 to
069d134
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
069d134 to
da5acd8
Compare
Close #3129
Call workflow complete handler on all workflow errors, including session
abort()(as well as other shutdown callbacks and observers).