[stable8] fix(NcAppContent): list is not scrollable on mobile#8289
Merged
Conversation
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Contributor
|
Title and labels are adjusted for the changelog generation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8289 +/- ##
========================================
Coverage 45.94% 45.94%
========================================
Files 193 193
Lines 4878 4878
Branches 1197 1259 +62
========================================
Hits 2241 2241
+ Misses 2551 2549 -2
- Partials 86 88 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
approved these changes
Mar 11, 2026
Antreesy
approved these changes
Mar 11, 2026
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Looks good with applied changes!
Contributor
|
/backport to main |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
As regression from https://github.com/nextcloud-libraries/nextcloud-vue/pull/6261/changes. Previously, there was no div, and a list was directly in the parent with height: 100%. After this change there was a
<div>created between parent and list with no height limit.Done: added a height between parent and list.
🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable