[stable8] fix: use provided appName of NcContent if possible#8160
Merged
Conversation
We already pass `appName` to `NcContent` and we provide this value. So we should make use of this whenever possible. Reason here is if e.g. library is used without the `appName` replacement, or if the app has multiple "sub-apps". One example here is Nextcloud core which has one global `appName` but multiple real app names (e.g. `files`, `files_sharing` etc). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8c1c3b2 to
6b0418b
Compare
susnux
approved these changes
Feb 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8160 +/- ##
===========================================
+ Coverage 46.01% 46.03% +0.02%
===========================================
Files 192 192
Lines 4762 4764 +2
Branches 1227 1227
===========================================
+ Hits 2191 2193 +2
Misses 2483 2483
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Antreesy
approved these changes
Feb 3, 2026
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Identical, so I guess, good
Merged
susnux
added a commit
that referenced
this pull request
Mar 4, 2026
- Missing piece for #8160 On main we already doing so but it was missing in stable8. Causing wrong app names in server apps. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8157
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.