Skip to content

[stable8] feat(NcRadioGroupButton): add disabled state styling to NcRadioGroupButton #8126

Merged
susnux merged 3 commits into
stable8from
backport/8118/stable8
Jan 27, 2026
Merged

[stable8] feat(NcRadioGroupButton): add disabled state styling to NcRadioGroupButton #8126
susnux merged 3 commits into
stable8from
backport/8118/stable8

Conversation

@backportbot

@backportbot backportbot Bot commented Jan 27, 2026 •
edited by ShGKme
Loading

Copy link
Copy Markdown

Backport of #8118

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot Bot requested review from ShGKme and susnux January 27, 2026 03:07
@backportbot backportbot Bot added enhancement New feature or request 3. to review Waiting for reviews labels Jan 27, 2026
@backportbot backportbot Bot added this to the 8.36.0 milestone Jan 27, 2026
@nikhil2297 @ShGKme
feat: add disabled state styling to NcRadioGroupButton
cbf8238 
Signed-off-by: nikhil2297 <nikhillohar2297@gmail.com>
@nikhil2297 @ShGKme
style: update css and code style
04104c6 
Signed-off-by: nikhil2297 <nikhillohar2297@gmail.com>
@ShGKme ShGKme force-pushed the backport/8118/stable8 branch from 7815f3d to 04104c6 Compare January 27, 2026 10:44
@ShGKme
chore(jest): include variables.scss in tests
9d78adc 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme marked this pull request as ready for review January 27, 2026 10:56
@codecov

codecov Bot commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.01%. Comparing base (d64b608) to head (9d78adc).
⚠️ Report is 15 commits behind head on stable8.

Files with missing lines Patch % Lines
...mponents/NcRadioGroupButton/NcRadioGroupButton.vue 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           stable8    #8126      +/-   ##
===========================================
- Coverage    46.02%   46.01%   -0.02%     
===========================================
  Files          192      192              
  Lines         4760     4762       +2     
  Branches      1226     1166      -60     
===========================================
  Hits          2191     2191              
- Misses        2481     2485       +4     
+ Partials        88       86       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux merged commit 86d1629 into stable8 Jan 27, 2026
19 of 23 checks passed
@susnux susnux deleted the backport/8118/stable8 branch January 27, 2026 11:48
@artonge artonge mentioned this pull request Feb 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Milestone

8.36.0

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux @ShGKme @nikhil2297