feat(NcRadioGroupButton): add disabled state styling to NcRadioGroupButton #8118
Merged
susnux merged 2 commits intoJan 27, 2026
Merged
Conversation
Signed-off-by: nikhil2297 <nikhillohar2297@gmail.com>
ShGKme
reviewed
Jan 26, 2026
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Thanks, one some small notes.
| <div | ||
| :class="[{ | ||
| [$style.radioGroupButton_active]: isChecked, | ||
| [$style.radioGroupButton_disabled]: disabled, |
Contributor
There was a problem hiding this comment.
Note for reviewers: we could use:has(:disabled) here, but adding a class is cheaper (:has() is an expensive selector) and simplified styles.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8118 +/- ##
=======================================
Coverage 52.77% 52.77%
=======================================
Files 103 103
Lines 3348 3348
Branches 976 976
=======================================
Hits 1767 1767
Misses 1333 1333
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: nikhil2297 <nikhillohar2297@gmail.com>
Contributor
Author
susnux
approved these changes
Jan 27, 2026
Contributor
|
/backport to stable8 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disabledstate #7930☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable