[next] feat!: rename checked prop to modelValue#4994
Merged
Conversation
checked prop to modelValue
skjnldsv
approved these changes
Dec 26, 2023
ShGKme
approved these changes
Dec 26, 2023
checked prop to modelValuechecked prop to modelValue
susnux
approved these changes
Dec 26, 2023
susnux
left a comment
Contributor
There was a problem hiding this comment.
Agree with the comments about the kebab case but otherwise fine!
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
06136e5 to
8dc7876
Compare
Contributor
Author
I fixed the kebab case issue. I should've known, since we use it like this every where else. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
v-modelcapabilities new to vue 3. Thecheckedprop ofNcActionCheckbox,NcActionRadioandNcCheckboxRadioSwitchwas renamed tomodelValueso the component can be used easier by simply providingv-model="isChecked"instead ofv-model:checked="isChecked".Companion PR to #4990.