[next] fix: unify modelValue naming#4990
Merged
Merged
Conversation
9ee6504 to
eac4c2e
Compare
modelValue naming
eac4c2e to
4602c34
Compare
ShGKme
requested changes
Dec 24, 2023
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
I think, modelValue should be used only in a meaning of a model, controlled value of the component, not a name for value.
Then it would align with Vue's model (input[type=checkbox] has v-model for checked, not value) and meaning of v-model directive (there always would be update:modelValue for updating component's model).
Contributor
Author
|
@ShGKme Thanks for the insight. I didn't look at it this way yet, but I think it makes sense. I will adjust the PR accordingly. |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
4602c34 to
6514aa3
Compare
Contributor
Author
|
I adjusted the PR. It now only contains changes related to renaming |
ShGKme
approved these changes
Dec 25, 2023
skjnldsv
approved these changes
Dec 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
value / modelValue. Everyvalueprop got renamed tomodelValueto align with the new usage by vue 3. For some components we did this already, so here I migrated the rest to have it consistent.