fix(win32): avoid displaying certificate warning on first connection #9160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows fetches unknown but trusted root CAs on demand from Windows Update. Qt will allow for the on-demand fetching of root CAs until at `setCaCertificates`/`addCaCertificates` was called. As this is done in the setup wizard for handling client SSL certificates, the `QSslConfiguration::systemCaCertificates` list would not include the newly-fetched certificate just yet. Fixes #8686 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Member
Author
|
/backport to stable-4.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9160.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows fetches unknown but trusted root CAs on demand from Windows Update. Qt will allow for the on-demand fetching of root CAs until at
setCaCertificates/addCaCertificateswas called.As this is done in the setup wizard for handling client SSL certificates, the
QSslConfiguration::systemCaCertificateslist would not include the newly-fetched certificate just yet.Fixes #8686