feat: Replaced Unified Logging System with Custom Solution. #8792
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Unified Logging System (OSLog) with a custom logging solution from NextcloudFileProviderKit. It removes debug archive functionality and updates the NextcloudKit dependency, while improving data cleanup for file provider domains.
- Replaces OSLog-based logging with custom FileProviderLogger throughout the codebase
- Removes debug archive creation functionality that was specific to the old logging system
- Adds improved file provider domain data cleanup when domains are removed
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libsync/configfile.h/cpp | Adds method to remove file provider domain mapping by domain identifier |
| src/gui/macOS/*.mm/h | Removes debug archive functionality and adds utilities for accessing file provider extension directories |
| src/gui/generalsettings.cpp | Updates debug archive creation to collect logs from file system instead of programmatic extraction |
| shell_integration/MacOSX/NextcloudIntegration/ | Mass replacement of OSLog Logger with NextcloudFileProviderKit's FileProviderLogger across all Swift/Objective-C files |
Comments suppressed due to low confidence (1)
shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareTableViewDataSource.swift:53
- The userId parameter is incorrectly set to account.username instead of account.id. This could cause authentication issues as the user ID and username are different values.
kit.appendSession(
account: account.ncKitAccount,
urlBase: account.serverUrl,
user: account.username,
userId: account.username,
password: account.password,
userAgent: userAgent,
groupIdentifier: ""
)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareController.swift
Show resolved
Hide resolved
767ce1e to
86ae112
Compare
- Removed explicit reference to NextcloudKit dependency which implicitly is pulled in already by NextcloudFileProviderKit. - Consolidated some source code files into their respective view controllers in the file provider UI extension. Signed-off-by: Iva Horn <iva.horn@icloud.com>
86ae112 to
6c5ee7c
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8792.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Uh oh!
There was an error while loading. Please reload this page.