Replaced Unified Logging System with Custom Solution #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the unified logging system with a custom logging solution specifically designed for file provider extensions. The custom solution provides structured JSON logging to files while maintaining compatibility with the unified logging system as a fallback.
- Introduces a new custom logging system with structured JSON file output
- Replaces all unified logging calls throughout the codebase with the new logging API
- Adds mock logging implementations for testing
Reviewed Changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/NextcloudFileProviderKit/Log/ | New custom logging implementation with protocol, logger, and file management |
| Sources/NextcloudFileProviderKitMocks/ | Mock logging implementation for tests |
| Multiple test files | Updated to import mocks and pass log parameter to constructors |
| Multiple source files | Replaced unified logging calls with custom logging API calls |
| Package.swift | Added NextcloudFileProviderKitMocks target |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sources/NextcloudFileProviderKit/Log/FileProviderLogMessage.swift
Outdated
Show resolved
Hide resolved
Sources/NextcloudFileProviderKit/Enumeration/Enumerator+Trash.swift
Outdated
Show resolved
Hide resolved
camilasan
reviewed
Sep 24, 2025
Signed-off-by: Iva Horn <iva.horn@icloud.com>
camilasan
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98.
It is not perfect yet and not every call consistently using the details argument but it is a start.