Feature/bulk create windows placeholders per folders (V1) #8568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
version 1 of the optimized creation of Windows placeholder items (version 2 is #8547 which needs more love and may bring even faster sync) |
e11d48c to
9894592
Compare
9894592 to
1f5a3ad
Compare
nilsding
requested changes
Aug 22, 2025
nilsding
reviewed
Aug 22, 2025
d731c08 to
e7bff8e
Compare
nilsding
requested changes
Aug 26, 2025
5b50206 to
787df85
Compare
nilsding
requested changes
Aug 29, 2025
nilsding
approved these changes
Aug 29, 2025
6aa8b0b to
3bc8a0c
Compare
try to use const and auto as much as possible remove useless constructor argument that is always using the default value makes code cleaner Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
this code does not make sense I tested manually and this code is never called I doubt this code is needed or useful Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
use the c++ standard way of requiring caller to care about the returned value Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should allow to speed API calls to Windows CfApi by reducing their numbers by asking for a list of new placeholders via a single call instead of one for each new item Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
use the proper VFS plug-in API to request all files to be cerated as a single batch will now need a proper implementation using the batch Windows CfApi function Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
filter new placeholder items by invalid modtime and only proceed with creating only the valid ones Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we should return false from BulkPropagatorDownloadJob::scheduleSelfOrChild() because we have no child jobs that are not done and waiting to be started ensure we update the job status only once (even in case of errors) ensure we update the state of the items once and only once Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
3bc8a0c to
1f0f5b0
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8568.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.