Skip to content

Feature/bulk create windows placeholders (v2) #8547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgallien wants to merge 3 commits into from
Closed

Feature/bulk create windows placeholders (v2) #8547

mgallien wants to merge 3 commits into from

Conversation

@mgallien
Copy link
Collaborator

@mgallien mgallien commented Aug 6, 2025

No description provided.

@mgallien mgallien added this to the 3.18.0 milestone Aug 6, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Aug 6, 2025
@mgallien mgallien moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Aug 6, 2025
@mgallien mgallien force-pushed the feature/bulkCreateWindowsPlaceholders branch 3 times, most recently from 2aaf543 to 4547bef Compare August 7, 2025 13:44
@mgallien mgallien self-assigned this Aug 8, 2025
@mgallien mgallien force-pushed the feature/bulkCreateWindowsPlaceholders branch from 4547bef to 9416bc3 Compare August 8, 2025 09:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6.1% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
67 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien force-pushed the feature/bulkCreateWindowsPlaceholders branch 3 times, most recently from eb7402b to c5c6558 Compare August 12, 2025 15:30
@mgallien mgallien mentioned this pull request Aug 12, 2025
Merged
@Rello Rello changed the title Feature/bulk create windows placeholders Feature/bulk create windows placeholders (v2) Aug 21, 2025
@Rello Rello moved this from 🏗️ In progress to 📄 To do in 💻 Desktop Clients team Aug 21, 2025
@mgallien mgallien modified the milestones: 4.0.0, 4.1.0 Oct 2, 2025
@mgallien
feat: use delayed tasks existing code for bulk virtual files creation
20237fd 
will reuse existing code to group together bulk upload iteams to also
group together the tasks to create new placeholder files during
propagation

having the new placeholders grouped only per folder is missing
optimization opportunities that we could have by having them grouped
globally

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
feat(windows/vfs): use the new batch create API for placeholder files
7273687 
use the proper VFS plug-in API to request all files to be cerated as a
single batch

will now need a proper implementation using the batch Windows CfApi
function

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/bulkCreateWindowsPlaceholders branch from c5c6558 to 1873bdd Compare October 2, 2025 09:14
@mgallien
feat(vfs/windows): use a single call to CfCreatePlaceholders for all
c1d96d2 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/bulkCreateWindowsPlaceholders branch from 1873bdd to c1d96d2 Compare October 2, 2025 09:49
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8547.zip

Digest: sha256:ff53479250c68cd39e8e617bea6115e2eb264a3db0ca500a7fff51839b3b5277

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Rello Rello moved this from 📄 To do to 🏗️ In progress in 💻 Desktop Clients team Oct 8, 2025
@mgallien
Copy link
Collaborator Author

mgallien commented Oct 9, 2025

closing for now

@mgallien mgallien closed this Oct 9, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio will be requested when the pull request is marked ready for review Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan will be requested when the pull request is marked ready for review camilasan is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 will be requested when the pull request is marked ready for review i2h3 is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding will be requested when the pull request is marked ready for review nilsding is a code owner

Assignees

@mgallien mgallien

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgallien