feat(vfs/folders): enable on demand fetch of folder content #8359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsding
reviewed
Jun 6, 2025
969881f to
045c43e
Compare
b30e9ed to
2e25647
Compare
02daeaa to
f4e6894
Compare
6d9c4ce to
9a911c7
Compare
00394d5 to
339046a
Compare
e69eecc to
d3a874f
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in autotests, we use some QList ensure we do not blindly access items in an empty list Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
prevent recursive discovery inside a virtual folder but do not prevent recursive discovery when needed Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
add a static method in LsColJob class moves some declaration to enable to reuse the code outside of its former implementation location Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
only add a Q_ASSERT for debug builds Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
on-demand populating of folders is breaking some tests for now, we expect the failures Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
avoid duplicating the list of common webdav properties Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
c3caa4f to
ef184cf
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8359.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Contributor
|
🎉🎉🎉🎉🎉 |
nilsding
added a commit
that referenced
this pull request
Oct 24, 2025
This temporarily reverts the on-demand parts of #8359. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
added a commit
that referenced
this pull request
Oct 24, 2025
This temporarily reverts the on-demand parts of #8359 and adds some fallbacks when encountering virtual directories from the sync db. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
added a commit
that referenced
this pull request
Oct 24, 2025
This temporarily reverts the on-demand parts of #8359 and adds some fallbacks when encountering virtual directories from the sync db. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
added a commit
that referenced
this pull request
Oct 24, 2025
This temporarily reverts the on-demand parts of #8359 and adds some fallbacks when encountering virtual directories from the sync db. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
added a commit
that referenced
this pull request
Oct 27, 2025
This temporarily reverts the on-demand parts of #8359 and adds some fallbacks when encountering virtual directories from the sync db. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
memurats
pushed a commit
to nextmcloud/desktop
that referenced
this pull request
Nov 14, 2025
This temporarily reverts the on-demand parts of nextcloud#8359 and adds some fallbacks when encountering virtual directories from the sync db. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
memurats
pushed a commit
to nextmcloud/desktop
that referenced
this pull request
Nov 14, 2025
This temporarily reverts the on-demand parts of nextcloud#8359 and adds some fallbacks when encountering virtual directories from the sync db. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will enable to dynamically fetch the list of files inside a folder
for now, only basic infrastructure plugging into CfApi is there