feat(provider): add Dropbox by manishrc · Pull Request #1756 · nextauthjs/next-auth

manishrc · 2021-04-18T04:57:57Z

What:

Add dropbox provider
Add documentation for dropbox

How:

Add provider similar to other providers.
Since dropbox does not support GET for Profile, conditionally used POST if provider is Dropbox.

Checklist:

Documentation
Tests N/A
Ready to be merged

vercel · 2021-04-18T04:58:02Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/4DxPvd7Ko8wGXgCJY3S44Puvvvrx
✅ Preview: https://next-auth-git-fork-manishrc-feat-add-provider-dropb-f4148b.vercel.app

balazsorban44

Just a few small comments, otherwise looking good! So I assume you have tested these all locally, right? Currently, we don't have any robust test setup, so we kind of rely on the ones implementing providers that they test it out before committing. 🙈

michalbundyra · 2021-04-23T11:16:23Z

Just to note here - we need to add the new provider also to types -

next-auth/types/providers.d.ts

Line 56 in 55a2932

export type OAuthProviderType =

(per #1773)
Thanks! :)

…auth into feat/add-provider-dropbox

Co-authored-by: Balázs Orbán <info@balazsorban.com>

manishrc · 2021-04-29T17:22:47Z

UPDATE: Looks like it was a problem with npm link after the nextjs app was moved to its own folder.
Tested and this now works.

I've made all of the suggested changes. But I'm now seeing the below error after merging main to this branch:

Unhandled Runtime Error

TypeError: Cannot use 'in' operator to search for 'undefined' in null

next-auth/client/index.js (166:16) @ _callee7$

  164 | 
  165 |   // Redirect to sign in page if no valid provider specified
> 166 |   if (!(provider in providers)) {
      |                ^
  167 |     // If Provider not recognized, redirect to sign in page
  168 |     window.location = `${baseUrl}/signin?callbackUrl=${encodeURIComponent(callbackUrl)}`
  169 |     return

Call Stack

tryCatch
node_modules/regenerator-runtime/runtime.js (63:14)
Generator.invoke [as _invoke]
node_modules/regenerator-runtime/runtime.js (293:0)
Generator.eval [as next]
node_modules/regenerator-runtime/runtime.js (118:0)
asyncGeneratorStep
node_modules/@babel/runtime/helpers/esm/asyncToGenerator.js (3:0)
_next
node_modules/@babel/runtime/helpers/esm/asyncToGenerator.js (25:0)

Co-authored-by: Adam Bergman <adam@fransvilhelm.com>

Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: Adam Bergman <adam@fransvilhelm.com>

manishrc added 3 commits April 18, 2021 10:09

feat(provider): add Dropbox provider

a0b4496

docs(provider): add Dropbox provider

46ccb38

fix(provider): reduce Dropbox scope to minimal

9c9c3d0

vercel Bot temporarily deployed to Preview April 18, 2021 04:58 Inactive

github-actions Bot added core Refers to `@auth/core` docs Relates to documentation providers labels Apr 18, 2021

Merge branch 'main' into feat/add-provider-dropbox

747d8be

vercel Bot temporarily deployed to Preview April 18, 2021 04:59 Inactive

balazsorban44 suggested changes Apr 19, 2021

View reviewed changes

Comment thread src/server/lib/oauth/client.js

Comment thread src/providers/dropbox.js Outdated

balazsorban44 changed the title ~~Add provider: Dropbox~~ feat(provider): add Dropbox Apr 19, 2021

balazsorban44 reviewed Apr 20, 2021

View reviewed changes

Comment thread src/providers/dropbox.js Outdated

balazsorban44 reviewed Apr 21, 2021

View reviewed changes

Comment thread src/providers/index.js Outdated

balazsorban44 mentioned this pull request Apr 26, 2021

RFC: Improve OAuth provider configuration #1846

Closed

adambrgmn reviewed Apr 29, 2021

View reviewed changes

Comment thread src/providers/dropbox.js Outdated

balazsorban44 suggested changes Apr 29, 2021

View reviewed changes

Comment thread src/providers/dropbox.js Outdated

manishrc added 4 commits April 29, 2021 17:36

fix(provider): use named function export

07050cb

docs(provider): add JS doc comments

1c41608

fix(provider): fix typo in dropbox provider

73def1a

Merge branch 'feat/add-provider-dropbox' of github.com:manishrc/next-…

24ceb0f

…auth into feat/add-provider-dropbox

vercel Bot temporarily deployed to Preview April 29, 2021 12:11 Inactive

fix(provider): use state/pkce protection by default

22cd285

Co-authored-by: Balázs Orbán <info@balazsorban.com>

vercel Bot temporarily deployed to Preview April 29, 2021 12:12 Inactive

fix(provider): remove dropbox export

3112d3d

vercel Bot temporarily deployed to Preview April 29, 2021 12:15 Inactive

Merge branch 'main' into feat/add-provider-dropbox

fc96f44

vercel Bot temporarily deployed to Preview April 29, 2021 12:16 Inactive

fix(provider): add dropbox to OAuthProviderType

55287c3

manishrc requested a review from 0ubbe as a code owner April 29, 2021 12:19

vercel Bot temporarily deployed to Preview April 29, 2021 12:19 Inactive

github-actions Bot added the TypeScript Issues relating to TypeScript label Apr 29, 2021

fix(provider): fix typo

ce00811

vercel Bot temporarily deployed to Preview April 29, 2021 12:33 Inactive

manishrc requested a review from balazsorban44 April 29, 2021 18:00

adambrgmn reviewed May 3, 2021

View reviewed changes

Comment thread src/providers/dropbox.js Outdated

fix(provider): fix typo in docs

f1ab091

Co-authored-by: Adam Bergman <adam@fransvilhelm.com>

vercel Bot temporarily deployed to Preview May 4, 2021 16:01 Inactive

balazsorban44 approved these changes May 4, 2021

View reviewed changes

Merge branch 'main' into feat/add-provider-dropbox

8bb230e

vercel Bot temporarily deployed to Preview May 5, 2021 04:09 Inactive

Merge branch 'main' into feat/add-provider-dropbox

7983780

vercel Bot temporarily deployed to Preview May 5, 2021 17:32 Inactive

balazsorban44 merged commit 332e237 into nextauthjs:main May 5, 2021

ndom91 mentioned this pull request May 2, 2022

RFC: Autogenerate NEXTAUTH_SECRET env var for users as a part of the build process? #4499

Closed

mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024

feat(provider): add Dropbox (nextauthjs#1756)

51597c5

Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: Adam Bergman <adam@fransvilhelm.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(provider): add Dropbox#1756

feat(provider): add Dropbox#1756
balazsorban44 merged 16 commits into
nextauthjs:mainfrom
manishrc:feat/add-provider-dropbox

manishrc commented Apr 18, 2021

Uh oh!

vercel Bot commented Apr 18, 2021 •

edited

Loading

Uh oh!

balazsorban44 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michalbundyra commented Apr 23, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

manishrc commented Apr 29, 2021 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

manishrc commented Apr 18, 2021

Uh oh!

vercel Bot commented Apr 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balazsorban44 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michalbundyra commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manishrc commented Apr 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unhandled Runtime Error

Call Stack

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Apr 18, 2021 •

edited

Loading

michalbundyra commented Apr 23, 2021 •

edited

Loading

manishrc commented Apr 29, 2021 •

edited

Loading