Skip to content

feat: support vendors.busuanzi config#843

Merged
stevenjoezhang merged 3 commits intonext-theme:masterfrom
iamxiaojianzheng:feat/busuanzi-support-custom-url
Nov 3, 2024
Merged

feat: support vendors.busuanzi config#843
stevenjoezhang merged 3 commits intonext-theme:masterfrom
iamxiaojianzheng:feat/busuanzi-support-custom-url

Conversation

@iamxiaojianzheng
Copy link
Contributor

@iamxiaojianzheng iamxiaojianzheng commented Oct 24, 2024 •
edited
Loading

PR Checklist

  • The changes have been tested (for bug fixes / features).
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (e.g. formatting, linting).
  • Refactoring (no changes to functionality and APIs).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved: Default links are sometimes accessed abnormally

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:

How to use?

In NexT _config.yml:

# Show Views / Visitors of the website / page with busuanzi.
# For more information: http://ibruce.info/2015/04/04/busuanzi/
busuanzi_count:
  enable: false
  # Default url is https://busuanzi.ibruce.info/busuanzi/2.3/busuanzi.pure.mini.js
  # Or try more better https://cn.vercount.one/js
  custom_url: https://cn.vercount.one/js
  total_visitors: true
  total_visitors_icon: fa fa-user
  total_views: true
  total_views_icon: fa fa-eye
  post_views: true
  post_views_icon: far fa-eye

@welcome
Copy link

welcome bot commented Oct 24, 2024

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 24, 2024

This pull request contains changes to the configuration file. Please make sure the documentation in NexT website is changed or added.
Please edit relevant source files here: https://github.com/next-theme/theme-next-docs/tree/master/source/docs and create a pull request with the changes here: https://github.com/next-theme/theme-next-docs/pulls

iamxiaojianzheng added a commit to iamxiaojianzheng/theme-next-docs that referenced this pull request Oct 24, 2024
@iamxiaojianzheng
Update statistics-and-analytics.md
943520e 
about next-theme/hexo-theme-next#843
@coveralls
Copy link

coveralls commented Nov 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11649446984

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.446%
Totals Coverage Status
Change from base Build 10956680841: 0.0%
Covered Lines: 400
Relevant Lines: 405
💛 - Coveralls

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Nov 3, 2024

The NexT theme currently uses the vendor setting to manage custom links for third-party dependencies (you can search for theme.vendors in the source code to find them). For consistency, I have also moved the busuanzi setting into the vendor section.

@stevenjoezhang stevenjoezhang added this to the 8.21.1 milestone Nov 3, 2024
@stevenjoezhang
Copy link
Member

stevenjoezhang commented Nov 3, 2024

@iamxiaojianzheng Please sign our Contributor License Agreement, and I will merge it as soon as possible. Thank you!

@iamxiaojianzheng
Copy link
Contributor Author

iamxiaojianzheng commented Nov 3, 2024

done

@stevenjoezhang stevenjoezhang merged commit 4e6703b into next-theme:master Nov 3, 2024
@welcome
Copy link

welcome bot commented Nov 3, 2024

Congrats on merging your first pull request here! 🎉 How awesome!

@stevenjoezhang stevenjoezhang changed the title feat: support custom_url in busuanzi_court config feat: support vendors.busuanzi config Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AlliotTech AlliotTech AlliotTech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Configurations ⭐ Feature Layout 🔌 3rd Party Plugin

Projects

None yet

Milestone

8.21.1

Development

Successfully merging this pull request may close these issues.

5 participants

@iamxiaojianzheng @CLAassistant @coveralls @stevenjoezhang @AlliotTech