Skip to content

Update AWS instance type in GPU unit tests workflow from g6.xlarge to g5.xlarge#465

Merged
shi-eric merged 1 commit into
newton-physics:mainfrom
shi-eric:ershi/update-aws-instance-type
Jul 24, 2025
Merged

Update AWS instance type in GPU unit tests workflow from g6.xlarge to g5.xlarge#465
shi-eric merged 1 commit into
newton-physics:mainfrom
shi-eric:ershi/update-aws-instance-type

Conversation

@shi-eric

@shi-eric shi-eric commented Jul 23, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

It seems like we're having instance availability issues today with g6.xlarge

Newton Migration Guide

Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this MR.

  • The migration guide in docs/migration.rst is up-to date

Before your PR is "Ready for review"

  • All commits are signed-off to indicate that your contribution adheres to the Developer Certificate of Origin requirements
  • Necessary tests have been added and new examples are tested (see newton/tests/test_examples.py)
  • Documentation is up-to-date
  • Code passes formatting and linting checks with pre-commit run -a

Summary by CodeRabbit

  • Chores
    • Updated the AWS EC2 instance type used for GPU tests in GitHub Actions workflows. This change does not affect test logic or results.

@shi-eric
Update AWS instance type in GPU unit tests workflow from g6.xlarge to…
8f038fd 
… g5.xlarge

Signed-off-by: Eric Shi <ershi@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The AWS EC2 instance type specified for GPU test jobs in two GitHub Actions workflow files was updated from g6.xlarge to g5.xlarge. No other changes were made to workflow logic, environment variables, or job steps.

Changes

Files Change Summary
.github/workflows/pr_aws_gpu_tests.yml,
.github/workflows/push_aws_gpu_tests.yml		 Updated EC2 instance type from g6.xlarge to g5.xlarge for GPU test jobs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Note

⚡️ Unit Test Generation - Beta

CodeRabbit's unit test generation is now available in Beta! Automatically generate comprehensive unit tests for your code changes, ensuring better test coverage and catching edge cases you might miss. Our AI analyzes your code structure and creates tests that follow best practices and your project's testing patterns. Learn more here, or just try it under ✨ Finishing Touches.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5091199 and 8f038fd.

📒 Files selected for processing (2)
  • .github/workflows/pr_aws_gpu_tests.yml (1 hunks)
  • .github/workflows/push_aws_gpu_tests.yml (1 hunks)
🔇 Additional comments (2)
.github/workflows/push_aws_gpu_tests.yml (1)

6-6: Confirm region quota & AMI/driver compatibility for g5.xlarge.

The substitution is syntactically correct, but g5.xlarge has different GPU hardware (A10G 24 GB) than g6.xlarge (L4 24 GB).

  1. Double-check that the us-east-2 account has sufficient On-Demand quota for g5.xlarge; otherwise the workflow will still stall.
  2. The chosen “Deep Learning Base GPU Ubuntu 24.04” AMI should already include CUDA 12 drivers that support A10G, but verify that your test suite doesn’t rely on L4-specific features (SM 8.9 vs 8.6).
  3. Update any performance expectations/documentation accordingly (docs/migration.rst checklist).

No code change required—just a sanity check before merge.

.github/workflows/pr_aws_gpu_tests.yml (1)

6-6: Mirror the same verification for PR runs.

The change keeps both push/PR workflows in sync—good.
Replicate the quota and compatibility checks mentioned in the push-workflow comment to avoid PR-specific failures.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shi-eric shi-eric marked this pull request as ready for review July 24, 2025 00:30
@shi-eric shi-eric merged commit d050062 into newton-physics:main Jul 24, 2025
8 of 10 checks passed
@shi-eric shi-eric deleted the ershi/update-aws-instance-type branch July 24, 2025 00:30
@coderabbitai coderabbitai Bot mentioned this pull request Oct 1, 2025
Closed
4 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Nov 14, 2025
Merged
4 tasks
vidurv-nvidia pushed a commit to vidurv-nvidia/newton that referenced this pull request Mar 6, 2026
@kellyguo11
Bumps version to v2.2.0 (newton-physics#465)
fd805c2 
# Description

Bumps Isaac Lab version to v2.2.0.

## Type of change

- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
@coderabbitai coderabbitai Bot mentioned this pull request Mar 27, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shi-eric