Skip to content

Fix inertia matrix format in usd parser#439

Merged
eric-heiden merged 1 commit into
newton-physics:mainfrom
camevor:fix-usd-importer-inertia-mat33
Jul 18, 2025
Merged

Fix inertia matrix format in usd parser#439
eric-heiden merged 1 commit into
newton-physics:mainfrom
camevor:fix-usd-importer-inertia-mat33

Conversation

@camevor

@camevor camevor commented Jul 18, 2025

Copy link
Copy Markdown
Member

Description

In ModelBuilder, self.body_inertia is expected to be a list of wp.mat33. The USD parser could add a np.ndarray instead.

Newton Migration Guide

  • The migration guide in docs/migration.rst is up-to date

Before your PR is "Ready for review"

  • All commits are signed-off to indicate that your contribution adheres to the Developer Certificate of Origin requirements
  • Necessary tests have been added and new examples are tested (see newton/tests/test_examples.py)
  • Documentation is up-to-date
  • Code passes formatting and linting checks with pre-commit run -a

Summary by CodeRabbit

  • Refactor
    • Improved handling of inertia matrices for rigid bodies to ensure compatibility and consistency with the expected matrix type.

Signed-off-by: camevor <camevor@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The update changes how the inertia matrix for rigid bodies is assigned in the parse_usd function. Instead of storing the inertia as a NumPy array, the code now wraps it in a Warp 3x3 matrix type (wp.mat33) before assignment, ensuring explicit type consistency with Warp's matrix operations.

Changes

File(s) Change Summary
newton/utils/import_usd.py Modified parse_usd to assign body inertia using wp.mat33(inertia) instead of a NumPy array.

Sequence Diagram(s)

sequenceDiagram
    participant USDFile
    participant parse_usd
    participant builder

    USDFile->>parse_usd: Provide rigid body data (with PhysicsMassAPI)
    parse_usd->>parse_usd: Extract inertia as NumPy array
    parse_usd->>parse_usd: Wrap inertia in wp.mat33
    parse_usd->>builder: Assign body_inertia[body_id] = wp.mat33(inertia)
    parse_usd->>parse_usd: (If needed) Compute inverse inertia with wp.mat33
    parse_usd->>builder: Assign body_inv_inertia[body_id]
Loading
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov

codecov Bot commented Jul 18, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
newton/utils/import_usd.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df80c62 and 92d93d1.

📒 Files selected for processing (1)
  • newton/utils/import_usd.py (1 hunks)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run GPU Unit Tests on AWS EC2 (Pull Request)
🔇 Additional comments (1)
newton/utils/import_usd.py (1)

987-987: LGTM! Type consistency fix implemented correctly.

The change properly wraps the numpy array in wp.mat33() to ensure type consistency with the expected format in ModelBuilder.body_inertia.

Comment thread newton/utils/import_usd.py

@eric-heiden eric-heiden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eric-heiden eric-heiden merged commit c33caa8 into newton-physics:main Jul 18, 2025
10 checks passed
@camevor camevor deleted the fix-usd-importer-inertia-mat33 branch August 15, 2025 15:28
@coderabbitai coderabbitai Bot mentioned this pull request Jan 13, 2026
eric-heiden pushed a commit to eric-heiden/newton that referenced this pull request Jan 28, 2026
Signed-off-by: camevor <camevor@nvidia.com>
mmacklin pushed a commit to mmacklin/newton that referenced this pull request Apr 7, 2026
Signed-off-by: camevor <camevor@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants