Skip to content

add parallel linesearch option to MuJoCo solver#400

Merged
adenzler-nvidia merged 3 commits into
newton-physics:mainfrom
adenzler-nvidia:dev/adenzler/add-ls-parallel-option-mujoco
Jul 15, 2025
Merged

add parallel linesearch option to MuJoCo solver#400
adenzler-nvidia merged 3 commits into
newton-physics:mainfrom
adenzler-nvidia:dev/adenzler/add-ls-parallel-option-mujoco

Conversation

@adenzler-nvidia

@adenzler-nvidia adenzler-nvidia commented Jul 14, 2025

Copy link
Copy Markdown
Member

This change adds an initialization parameter to the MuJoCo solver to enable parallel linesearch. Parallel linesearch is generally faster, but it's unclear yet whether it is as good in terms of solver convergence as iterative linesearch. Having this flag here will allow downstream users to evaluate whether they can use parallel linesearch or not.

Before your PR is "Ready for review"

  • All commits are signed-off to indicate that your contribution adheres to the Developer Certificate of Origin requirements
  • Necessary tests have been added and new examples are tested (see newton/tests/test_examples.py)
  • Documentation is up-to-date
  • Code passes formatting and linting checks with pre-commit run -a

Summary by CodeRabbit

  • New Features
    • Added an option to enable or disable parallel line search in the MuJoCo solver via a new user-configurable setting. The default behavior remains unchanged unless this option is explicitly set.

Signed-off-by: Alain Denzler <adenzler@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

A new boolean parameter, ls_parallel, has been added to the MuJoCoSolver class constructor and its convert_to_mjc method, defaulting to False. This parameter is intended to enable parallel line search in MuJoCo and is passed through the constructor and conversion method but not further utilized in the shown code.

Changes

File(s) Change Summary
newton/solvers/mujoco/solver_mujoco.py Added ls_parallel: bool = False parameter to MuJoCoSolver constructor and convert_to_mjc method; passed ls_parallel through calls.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MuJoCoSolver
    participant MuJoCoModel

    User->>MuJoCoSolver: __init__(..., ls_parallel=False)
    MuJoCoSolver->>MuJoCoSolver: convert_to_mjc(..., ls_parallel)
    MuJoCoSolver->>MuJoCoModel: set opt.ls_parallel = ls_parallel
Loading

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2b7fee and 7a7c39d.

📒 Files selected for processing (1)
  • newton/solvers/mujoco/solver_mujoco.py (4 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adenzler-nvidia

Copy link
Copy Markdown
Member Author

cc @AntoineRichard

@adenzler-nvidia adenzler-nvidia enabled auto-merge (squash) July 14, 2025 16:15
@adenzler-nvidia adenzler-nvidia merged commit 37a9800 into newton-physics:main Jul 15, 2025
8 of 9 checks passed
eric-heiden pushed a commit to eric-heiden/newton that referenced this pull request Jan 28, 2026
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
mmacklin pushed a commit to mmacklin/newton that referenced this pull request Apr 7, 2026
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants