add parallel linesearch option to MuJoCo solver#400
Conversation
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughA new boolean parameter, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MuJoCoSolver
participant MuJoCoModel
User->>MuJoCoSolver: __init__(..., ls_parallel=False)
MuJoCoSolver->>MuJoCoSolver: convert_to_mjc(..., ls_parallel)
MuJoCoSolver->>MuJoCoModel: set opt.ls_parallel = ls_parallel
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
This change adds an initialization parameter to the MuJoCo solver to enable parallel linesearch. Parallel linesearch is generally faster, but it's unclear yet whether it is as good in terms of solver convergence as iterative linesearch. Having this flag here will allow downstream users to evaluate whether they can use parallel linesearch or not.
Before your PR is "Ready for review"
newton/tests/test_examples.py)pre-commit run -aSummary by CodeRabbit